Analysis fabpot / Silex #127 - SensioLabsInsight

in src/Silex/Provider/AssetServiceProvider.php, line 65


        $app['assets.named_packages'] = array();
        // prototypes
        $app['assets.strategy_factory'] = $app->protect(function ($version, $format, $jsonManifestPath, $name) use ($app) {This app use argument is declared but never used. You should remove it.
Time to fix: about 15 minutes

                Open Issue
             Permalink

                                    Last edited Thu, 15 Jun 2017 11:17:09 +0200 by MatTheCat
                    
            if ($version && $jsonManifestPath) {
                throw new \LogicException(sprintf('Asset package "%s" cannot have version and manifest.', $name));
            }
            if ($version) {

in src/Silex/Provider/SecurityServiceProvider.php, line 416

                );
            };
        });
        $app['security.user_provider.inmemory._proto'] = $app->protect(function ($params) use ($app) {
            return function () use ($app, $params) {This app use argument is declared but never used. You should remove it.
Time to fix: about 15 minutes

                Open Issue
             Permalink

                                    Last edited Mon, 11 Nov 2013 08:10:06 +0100 by Fabien Potencier
                    
                $users = array();
                foreach ($params as $name => $user) {
                    $users[$name] = array('roles' => (array) $user[0], 'password' => $user[1]);
                }

in src/Silex/Provider/SecurityServiceProvider.php, line 454

                return $handler;
            };
        });
        $app['security.authentication.failure_handler._proto'] = $app->protect(function ($name, $options) use ($app) {
            return function () use ($name, $options, $app) {This name use argument is declared but never used. You should remove it.
Time to fix: about 15 minutes

                Open Issue
             Permalink

                                    Last edited Mon, 11 Nov 2013 08:10:06 +0100 by Fabien Potencier
                    
                return new DefaultAuthenticationFailureHandler(
                    $app,
                    $app['security.http_utils'],
                    $options,
                    $app['logger']

in src/Silex/Provider/SecurityServiceProvider.php, line 465

                );
            };
        });
        $app['security.authentication_listener.guard._proto'] = $app->protect(function ($providerKey, $options) use ($app, $that) {
            return function () use ($app, $providerKey, $options, $that) {This that use argument is declared but never used. You should remove it.
Time to fix: about 15 minutes

                Open Issue
             Permalink

                                    Last edited Thu, 17 Dec 2015 00:09:13 +0100 by Jérôme Tamarelle
                    
                if (!isset($app['security.authentication.guard_handler'])) {
                    $app['security.authentication.guard_handler'] = new GuardAuthenticatorHandler($app['security.token_storage'], $app['dispatcher']);
                }
                $authenticators = array();

in src/Silex/Provider/SecurityServiceProvider.php, line 520

                );
            };
        });
        $app['security.authentication_listener.http._proto'] = $app->protect(function ($providerKey, $options) use ($app) {
            return function () use ($app, $providerKey, $options) {This options use argument is declared but never used. You should remove it.
Time to fix: about 15 minutes

                Open Issue
             Permalink

                                    Last edited Mon, 11 Nov 2013 08:10:06 +0100 by Fabien Potencier
                    
                return new BasicAuthenticationListener(
                    $app['security.token_storage'],
                    $app['security.authentication_manager'],
                    $providerKey,
                    $app['security.entry_point.'.$providerKey.'.http'],

in src/Silex/Provider/SecurityServiceProvider.php, line 532

                );
            };
        });
        $app['security.authentication_listener.anonymous._proto'] = $app->protect(function ($providerKey, $options) use ($app) {
            return function () use ($app, $providerKey, $options) {This options use argument is declared but never used. You should remove it.
Time to fix: about 15 minutes

                Open Issue
             Permalink

                                    Last edited Mon, 11 Nov 2013 08:10:06 +0100 by Fabien Potencier
                    
                return new AnonymousAuthenticationListener(
                    $app['security.token_storage'],
                    $providerKey,
                    $app['logger']
                );

in src/Silex/Provider/SecurityServiceProvider.php, line 542

                );
            };
        });
        $app['security.authentication.logout_handler._proto'] = $app->protect(function ($name, $options) use ($app) {
            return function () use ($name, $options, $app) {This name use argument is declared but never used. You should remove it.
Time to fix: about 15 minutes

                Open Issue
             Permalink

                                    Last edited Mon, 11 Nov 2013 08:10:06 +0100 by Fabien Potencier
                    
                return new DefaultLogoutSuccessHandler(
                    $app['security.http_utils'],
                    isset($options['target_url']) ? $options['target_url'] : '/'
                );
            };

in src/Silex/Provider/SecurityServiceProvider.php, line 580

                return $listener;
            };
        });
        $app['security.authentication_listener.switch_user._proto'] = $app->protect(function ($name, $options) use ($app, $that) {
            return function () use ($app, $name, $options, $that) {This that use argument is declared but never used. You should remove it.
Time to fix: about 15 minutes

                Open Issue
             Permalink

                                    Last edited Mon, 11 Nov 2013 08:10:06 +0100 by Fabien Potencier
                    
                return new SwitchUserListener(
                    $app['security.token_storage'],
                    $app['security.user_provider.'.$name],
                    $app['security.user_checker'],
                    $name,

in src/Silex/Provider/SecurityServiceProvider.php, line 605

                return new FormAuthenticationEntryPoint($app, $app['security.http_utils'], $loginPath, $useForward);
            };
        });
        $app['security.entry_point.http._proto'] = $app->protect(function ($name, array $options) use ($app) {
            return function () use ($app, $name, $options) {This name use argument is declared but never used. You should remove it.
Time to fix: about 15 minutes

                Open Issue
             Permalink

                                    Last edited Mon, 11 Nov 2013 08:10:06 +0100 by Fabien Potencier
                    
                return new BasicAuthenticationEntryPoint(isset($options['real_name']) ? $options['real_name'] : 'Secured');
            };
        });
        $app['security.entry_point.guard._proto'] = $app->protect(function ($name, array $options) use ($app) {

in src/Silex/Provider/SecurityServiceProvider.php, line 605

                return new FormAuthenticationEntryPoint($app, $app['security.http_utils'], $loginPath, $useForward);
            };
        });
        $app['security.entry_point.http._proto'] = $app->protect(function ($name, array $options) use ($app) {
            return function () use ($app, $name, $options) {This app use argument is declared but never used. You should remove it.
Time to fix: about 15 minutes

                Open Issue
             Permalink

                                    Last edited Mon, 11 Nov 2013 08:10:06 +0100 by Fabien Potencier
                    
                return new BasicAuthenticationEntryPoint(isset($options['real_name']) ? $options['real_name'] : 'Secured');
            };
        });
        $app['security.entry_point.guard._proto'] = $app->protect(function ($name, array $options) use ($app) {

in src/Silex/Provider/SecurityServiceProvider.php, line 656

                );
            };
        });
        $app['security.authentication_provider.anonymous._proto'] = $app->protect(function ($name, $options) use ($app) {
            return function () use ($app, $name) {This app use argument is declared but never used. You should remove it.
Time to fix: about 15 minutes

                Open Issue
             Permalink

                                    Last edited Mon, 11 Nov 2013 08:10:06 +0100 by Fabien Potencier
                    
                return new AnonymousAuthenticationProvider($name);
            };
        });
        if (isset($app['validator'])) {

fabpot / Silex #127

Unused method, property, variable or parameter 11