Public methods in controller classes should only be actions (with the <code>Action</code> suffix)

  • Major
  • Architecture

More information: https://insight.sensiolabs.com/what-we-analyse/symfony.controller.non_action_public_method_in_controller_class

  1. /**
  2. * @param string $path
  3. * @return BinaryFileResponse
  4. */
  5. public function embed (string $path) : Response

    Non-action public method found in controller class

    Time to fix: about 1 hour
    Open Issue Permalink
    Last edited by Jannik Zschiesche
  6. {
  7. if (!$this->isDebug)
  8. {
  9. throw new NotFoundHttpException("Assets embedding disabled in prod.");
  10. }

Unused method, property, variable or parameter

  • Minor
  • Deadcode

More information: https://insight.sensiolabs.com/what-we-analyse/php.unused_local_variable_or_private_member

  1. /**
  2. * @var CacheWarmer
  3. */
  4. private $cacheWarmer;

    This cacheWarmer attribute is declared but never used. You should remove it.

    Time to fix: about 15 minutes
    Open Issue Permalink
    Last edited by Jannik Zschiesche
  5. /**
  6. * @var EntryNamespaces
  7. */