Text files should end with a newline character 2

  • Info
  • Codestyle

More information: https://insight.sensiolabs.com/what-we-analyse/missing_e_o_l

  1. /**
  2. * Adapters that implement this interface let the Filesystem know that it files can be overwritten using the write
  3. * functions and don't need the update function to be called. This can help improve performance when asserts are disabled.
  4. */
  5. interface CanOverwriteFiles {}

    This file ends with no newline character. It won't render properly on a terminal, and it's considered a bad practice. Add a simple line feed as the last character to fix it.

    Time to fix: about 15 minutes
    Open Issue Permalink
    Last edited by Frank de Jonge
  1. public function getVisibility($path)
  2. {
  3. }
  4. }

    This file ends with no newline character. It won't render properly on a terminal, and it's considered a bad practice. Add a simple line feed as the last character to fix it.

    Time to fix: about 15 minutes
    Open Issue Permalink
    Last edited by Frank de Jonge

Interfaces names should end with "Interface"

  • Info
  • Codestyle

More information: https://insight.sensiolabs.com/what-we-analyse/php.interface_has_no_interface_suffix

  1. /**
  2. * Adapters that implement this interface let the Filesystem know that it files can be overwritten using the write
  3. * functions and don't need the update function to be called. This can help improve performance when asserts are disabled.
  4. */
  5. interface CanOverwriteFiles {}

    Interface CanOverwriteFiles should be named CanOverwriteFilesInterface for better clarity.

    Time to fix: about 1 hour
    Open Issue Permalink
    Last edited by Frank de Jonge