Analysis tobias / cache-bundle #150

Absolute path constants __DIR__ and __FILE__ should not be used

Major

Bugrisk

More information: https://insight.sensiolabs.com/what-we-analyse/symfony.dependency_injection.use_dir_file_constant

in src/DataCollector/ProxyFactory.php, line 58

            require $proxyFile;
            return $proxyClass;
        }
        $content = file_get_contents(dirname(__DIR__).'/Resources/proxy/template.php');__DIR__ and __FILE__ constants may conflict with the Symfony resource overriding system
Time to fix: about 2 hours

                Open Issue
             Permalink

                                    Last edited Sun, 30 Jul 2017 21:16:17 +0200 by Tobias Nyholm
                    
        $content = str_replace('__TPL_CLASS__', $proxyClass, $content);
        $content = str_replace('__TPL_EXTENDS__', $class, $content);
        $this->checkProxyDirectory();
        file_put_contents($proxyFile, $content);

Unused method, property, variable or parameter

Minor

Deadcode

More information: https://insight.sensiolabs.com/what-we-analyse/php.unused_local_variable_or_private_member

in src/Resources/proxy/template.php, line 18

use Cache\CacheBundle\DataCollector\TraceableAdapterEvent;
use Psr\Cache\CacheItemInterface;
class __TPL_CLASS__ extends __TPL_EXTENDS__ implements CacheProxyInterface
{
    private $__name;This __name attribute is declared but never used. You should remove it.
Time to fix: about 15 minutes

                Open Issue
             Permalink

                                    Last edited Sun, 30 Jul 2017 21:16:17 +0200 by Tobias Nyholm
                    
    private $__calls = [];
    public function getItem($key)
    {
        $event = $this->start(__FUNCTION__, $key);