Source code should not contain TODO comments 3

  • Minor
  • Architecture

More information: https://insight.sensiolabs.com/what-we-analyse/task_todo_comment

  1. if ($user) {
  2. $this->auth->login($user);
  3. return $response->withRedirect($this->router->pathFor('dashboard'));
  4. } else {
  5. // ToDo: handle failed login

    TODO comments are left in the code when a feature (or a bug) isn't completely developed (or fixed). You should complete the implementation and remove the comment.

    Time to fix: about 4 hours
    Open Issue Permalink
    Last edited by Sarcoma
  6. echo "Nope";
  7. }
  8. }
  9. return $this->view->render($response, 'auth/index.twig');
  1. $user = $this->auth->register($request);
  2. if (!$user) {
  3. return $response->withRedirect($this->router->pathFor('register'));
  4. }
  5. }
  6. // ToDo: Flash message that sign up has been successful

    TODO comments are left in the code when a feature (or a bug) isn't completely developed (or fixed). You should complete the implementation and remove the comment.

    Time to fix: about 4 hours
    Open Issue Permalink
    Last edited by Sarcoma
  7. // ToDo: Send email with registration code to authenticate user
  8. return $this->view->render($response, 'auth/register.twig');
  9. }
  10. public function logoutAction(Request $request, Response $response, $args = [])
  1. if (!$user) {
  2. return $response->withRedirect($this->router->pathFor('register'));
  3. }
  4. }
  5. // ToDo: Flash message that sign up has been successful
  6. // ToDo: Send email with registration code to authenticate user

    TODO comments are left in the code when a feature (or a bug) isn't completely developed (or fixed). You should complete the implementation and remove the comment.

    Time to fix: about 4 hours
    Open Issue Permalink
    Last edited by Sarcoma
  7. return $this->view->render($response, 'auth/register.twig');
  8. }
  9. public function logoutAction(Request $request, Response $response, $args = [])
  10. {

User specific files should not appear in .gitignore

  • Minor
  • Codestyle

More information: https://insight.sensiolabs.com/what-we-analyse/git.user_specific_ignored_file

in .gitignore, line 22
  1. .idea/**/dataSources.xml
  2. .idea/**/dataSources.local.xml
  3. .idea/**/sqlDataSources.xml
  4. .idea/**/dynamic.xml
  5. .idea/**/uiDesigner.xml
  6. .idea/

    .idea/ is user-specific and should not appear in a project .gitignore. Consider adding it to the user global .gitignore instead.

    Time to fix: about 15 minutes
    Open Issue Permalink
    Last edited by Sarcoma
  7. # Gradle:
  8. .idea/**/gradle.xml
  9. .idea/**/libraries

.htaccess should be avoided

  • Info
  • Performance

More information: https://insight.sensiolabs.com/what-we-analyse/web.apache_config

A .htaccess file has been spotted. You should consider moving it to the server configuration to improve global performances.

Time to fix: about 1 hour
Open Issue Permalink
Collective